[PATCH] D101819: [M68k][GloballSel] Adding initial GlobalISel infrastructure

Min-Yih Hsu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 13 14:44:23 PDT 2021


myhsu added a comment.

I recommend you to check the "Done" checkbox by an inline comment when you resolve a comment. With that you can easily navigate through unresolved comments by clicking on the "X/Y Comments" button on the top-right corner.



================
Comment at: llvm/lib/Target/M68k/GlSel/M68kCallLowering.h:1
+//===-- M68kCallLowering.cpp - Call lowering -------------------*- C++ -*-===//
+//
----------------
this should be .h not .cpp, I think you forget to change this when copy the comments


================
Comment at: llvm/lib/Target/M68k/GlSel/M68kLegalizerInfo.h:9
+/// \file
+/// This file declares the targeting of the Machinelegalizer class for M68k.
+//===----------------------------------------------------------------------===//
----------------
myhsu wrote:
> 
still outstanding


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101819/new/

https://reviews.llvm.org/D101819



More information about the llvm-commits mailing list