[PATCH] D102763: [LLParser] Remove outdated deplibs

[Duncan P. N. Exon Smith via Phabricator via llvm-commits]

dexonsmith accepted this revision.
dexonsmith added a comment.

In D102763#2815285 <https://reviews.llvm.org/D102763#2815285>, @compnerd wrote:

> Given the thread on the mailing list, I think that this is fine as long as there is an accompanying test to validate the bitcode deserialization continues to work.  Id wait a few days more to see if @dexonsmith has an opinion.

LGTM too (sorry for any delay; on vacation).

Note two historical quirks about this "Remove in 4.0" comment, which has experienced some bitrot.

1. In the past, the community assumed that 4.0 would break compatibility with 3.x (like 3.0 did with 2.x). We since dropped that (and went from 3.9 to 4.0 without breaking compatibility), but I guess some of the boilerplate comments are still around. I think such comments in the bitcode parser were already removed since we don't anticipate breaking compatibility "ever".
2. In the past, LLVM parsed (and auto-upgraded) old textual IR. At some point we dropped that requirement. We still parse some non-canonical forms of textual IR as a convenience (mainly to avoid having to update old testcases), but we're allowed to break compatibility when it "makes sense", unrelated to specific version numbers.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102763/new/

https://reviews.llvm.org/D102763