[PATCH] D104059: [WIP][Attributor] Derive AACallEdges attribute

Kuter Dinel via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 13 12:23:32 PDT 2021


kuter marked 2 inline comments as done.
kuter added inline comments.


================
Comment at: llvm/include/llvm/Transforms/IPO/Attributor.h:3935
+  /// Reference to Attributor needed for GraphTraits implementation.
+  Attributor &A;
+  friend CallEdgeIterator;
----------------
jdoerfert wrote:
> Don't store the Attributor instance, let the user pass it where needed.
I wanted not to but we need this to have a `GraphTraits` implementation.
`GraphTraits::child_begin` only takes the node itself and we need `Attributor` to  create the `AACallEdges`.
I don't think there are any other way to inject the Attributor inside `GraphTraits::child_begin` 


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104059/new/

https://reviews.llvm.org/D104059



More information about the llvm-commits mailing list