[lld] 7d4c8a2 - [lld/mac] clarify comment

Nico Weber via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 13 10:30:44 PDT 2021


Author: Nico Weber
Date: 2021-06-13T13:30:07-04:00
New Revision: 7d4c8a2b8f16a2d1cf8120c75d941e99b8a8200a

URL: https://github.com/llvm/llvm-project/commit/7d4c8a2b8f16a2d1cf8120c75d941e99b8a8200a
DIFF: https://github.com/llvm/llvm-project/commit/7d4c8a2b8f16a2d1cf8120c75d941e99b8a8200a.diff

LOG: [lld/mac] clarify comment

This is a "we should do X in the future" fixme, not an "X might go wrong"
fixme.

Added: 
    

Modified: 
    lld/MachO/UnwindInfoSection.cpp

Removed: 
    


################################################################################
diff  --git a/lld/MachO/UnwindInfoSection.cpp b/lld/MachO/UnwindInfoSection.cpp
index d024b335702e..80f6212d97e3 100644
--- a/lld/MachO/UnwindInfoSection.cpp
+++ b/lld/MachO/UnwindInfoSection.cpp
@@ -138,7 +138,7 @@ void UnwindInfoSectionImpl<Ptr>::prepareRelocations(ConcatInputSection *isec) {
   assert(!isec->shouldOmitFromOutput() &&
          "__compact_unwind section should not be omitted");
 
-  // FIXME: This could skip relocations for CompactUnwindEntries that
+  // FIXME: Make this skip relocations for CompactUnwindEntries that
   // point to dead-stripped functions. That might save some amount of
   // work. But since there are usually just few personality functions
   // that are referenced from many places, at least some of them likely


        


More information about the llvm-commits mailing list