[PATCH] D104194: Fix misspelled instruction in X86 assembly parser

Eric Astor via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sun Jun 13 08:05:20 PDT 2021


epastor created this revision.
epastor added reviewers: MaskRay, mstorsjo.
Herald added subscribers: pengfei, hiraditya.
epastor requested review of this revision.
Herald added a reviewer: jdoerfert.
Herald added subscribers: llvm-commits, sstefan1.
Herald added a project: LLVM.

Did not correctly handle "jecxz short <address>".

Discovered while working on LLVM-ML; shows up in z_Windows_NT-586_asm.asm from the OpenMP runtime


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104194

Files:
  llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp


Index: llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
===================================================================
--- llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
+++ llvm/lib/Target/X86/AsmParser/X86AsmParser.cpp
@@ -3101,7 +3101,7 @@
   // Hack to skip "short" following Jcc.
   if (isParsingIntelSyntax() &&
       (PatchedName == "jmp" || PatchedName == "jc" || PatchedName == "jnc" ||
-       PatchedName == "jcxz" || PatchedName == "jexcz" ||
+       PatchedName == "jcxz" || PatchedName == "jecxz" ||
        (PatchedName.startswith("j") &&
         ParseConditionCode(PatchedName.substr(1)) != X86::COND_INVALID))) {
     StringRef NextTok = Parser.getTok().getString();


-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104194.351719.patch
Type: text/x-patch
Size: 689 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210613/f6c800da/attachment.bin>


More information about the llvm-commits mailing list