[PATCH] D104164: Remove __llvm_mipmap section in llvm-strip

[Alexander Shaposhnikov via Phabricator via llvm-commits]

alexshap added a comment.

my 0.02$ - (the diff lacks tests, isDebugSection has a more specific meaning in this context - but these are minor concerns), the main concern - I'm not sure that putting this logic into llvm-objcopy is a good idea, there are many tools which create extra sections and making llvm-objcopy aware of them doesn't feel right. Btw - llvm-strip has --remove-section as well, so e.g. you can simply add it to the same invocation of the tool, no need to run it as a separate build step. But I'd like to hear what others think, cc @jhenderson, @MaskRay


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104164/new/

https://reviews.llvm.org/D104164