[llvm] aa93603 - [runtimes] Fix umbrella component targets

Shoaib Meenai via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 12 19:50:30 PDT 2021


Author: Shoaib Meenai
Date: 2021-06-12T19:49:44-07:00
New Revision: aa93603ff6a4bfd92c64e4f75d60ae9c84d5cdf5

URL: https://github.com/llvm/llvm-project/commit/aa93603ff6a4bfd92c64e4f75d60ae9c84d5cdf5
DIFF: https://github.com/llvm/llvm-project/commit/aa93603ff6a4bfd92c64e4f75d60ae9c84d5cdf5.diff

LOG: [runtimes] Fix umbrella component targets

When we're building the runtimes for multiple platform targets, we
create umbrella build targets for each distribution component, but those
targets didn't have any dependencies and were just no-ops. Make the
umbrella target depend on the sub-targets for each platform to fix this,
which is consistent with the behavior of the umbrella targets for each
runtime, and also consistent with the behavior when we've only specified
the default target.

Added: 
    

Modified: 
    llvm/runtimes/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/runtimes/CMakeLists.txt b/llvm/runtimes/CMakeLists.txt
index 07a438bf581c7..6ae087ef62dda 100644
--- a/llvm/runtimes/CMakeLists.txt
+++ b/llvm/runtimes/CMakeLists.txt
@@ -401,6 +401,11 @@ if(runtimes)
         add_dependencies(install-${runtime_name} install-${runtime_name}-${name})
         add_dependencies(install-${runtime_name}-stripped install-${runtime_name}-${name}-stripped)
       endforeach()
+      foreach(component ${LLVM_RUNTIME_DISTRIBUTION_COMPONENTS})
+        add_dependencies(${component} ${component}-${name})
+        add_dependencies(install-${component} install-${component}-${name})
+        add_dependencies(install-${component}-stripped install-${component}-${name}-stripped)
+      endforeach()
     endforeach()
 
     foreach(multilib ${LLVM_RUNTIME_MULTILIBS})
@@ -418,6 +423,11 @@ if(runtimes)
           add_dependencies(install-${runtime_name} install-${runtime_name}-${name}+${multilib})
           add_dependencies(install-${runtime_name}-stripped install-${runtime_name}-${name}+${multilib}-stripped)
         endforeach()
+        foreach(component ${LLVM_RUNTIME_DISTRIBUTION_COMPONENTS})
+          add_dependencies(${component} ${component}-${name}+${multilib})
+          add_dependencies(install-${component} install-${component}-${name}+${multilib})
+          add_dependencies(install-${component}-stripped install-${component}-${name}+${multilib}-stripped)
+        endforeach()
       endforeach()
     endforeach()
   endif()


        


More information about the llvm-commits mailing list