[PATCH] D104185: [SPARC] Legalize truncation and extension between fp128 and half

LemonBoy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 12 11:19:20 PDT 2021


LemonBoy added a comment.

In D104185#2815375 <https://reviews.llvm.org/D104185#2815375>, @jrtc27 wrote:

> The diff looks fine but:
>
> (a) the commit title only mentions truncstore whilst this also fixes both general truncation and extension
> (b) the commit body doesn't mention extension

I'm bad at picking titles,

In D104185#2815375 <https://reviews.llvm.org/D104185#2815375>, @jrtc27 wrote:

> The diff looks fine but:
>
> (a) the commit title only mentions truncstore whilst this also fixes both general truncation and extension
> (b) the commit body doesn't mention extension

Fixing the extension was a side-effect, I've now updated the commit title and body.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104185/new/

https://reviews.llvm.org/D104185



More information about the llvm-commits mailing list