[PATCH] D99481: [InstCombine] Fix miscompile on GEP+load to icmp fold (PR45210)

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Sat Jun 12 10:46:45 PDT 2021


efriedma added inline comments.


================
Comment at: llvm/lib/Transforms/InstCombine/InstCombineCompares.cpp:378
   {
+    Idx = MaskIdx(Idx);
     Type *Ty = nullptr;
----------------
This doesn't look right; it's outside the "if (Ty) {" that actually guards the transform.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D99481/new/

https://reviews.llvm.org/D99481



More information about the llvm-commits mailing list