[PATCH] D103636: [AMDGPU][IndirectCalls] Fix register usage propagation for indirect/external calls

[Madhur Amilkanthwar via Phabricator via llvm-commits]

madhur13490 added inline comments.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:726-727
+  bool FunctionHasFlatScratchInit = false;
+  bool HasCalls = F.hasFnAttribute("amdgpu-calls");
+  bool HasStackObjects = F.hasFnAttribute("amdgpu-stack-objects");
+  if (hasFlatAddressSpace() && AMDGPU::isEntryFunctionCC(F.getCallingConv()) &&
----------------
arsenm wrote:
> madhur13490 wrote:
> > arsenm wrote:
> > > I don't like relying on these attributes. Can you just assume they are true?
> > But that will deviate from the current behavior. 
> OK, as a followup change, can you just make these assume true?
Sure, will try if PSDB passes.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103636/new/

https://reviews.llvm.org/D103636