[PATCH] D104131: [CSSPGO] Aggregation by the last K context frames for cold profiles

[Wenlei He via Phabricator via llvm-commits]

wenlei added inline comments.


================
Comment at: llvm/include/llvm/ProfileData/SampleProf.h:1014
+                                       bool MergeColdContext = true,
+                                       uint32_t KeepLastKFrames = 1);
   // Canonicalize context profile name and attributes.
----------------
Looks like all call site have explicit argument, do we still need a default one?


================
Comment at: llvm/tools/llvm-profgen/ProfileGenerator.cpp:47
+static cl::opt<uint32_t> CSProfKeepLastKFrames(
+    "csprof-keep-last-k-frames", cl::init(1), cl::ZeroOrMore,
+    cl::desc("Keep the last K frames while merging cold profile. 1 means the "
----------------
nit: how about name it `frame-depth-for-cold-context`? similar name for llvm-profdata flag and all variables.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104131/new/

https://reviews.llvm.org/D104131