[PATCH] D104060: Machine IR Profile

[Xinliang David Li via llvm-commits]

On Fri, Jun 11, 2021 at 5:52 PM Ellis Hoag via Phabricator <
reviews at reviews.llvm.org> wrote:

> ellis added a comment.
>
> @davidxl
>
> > Can you use the same set of benchmarks for comparison?
>
> I'm not sure what you mean. In
> https://gist.github.com/ellishg/92a68cf82bfdeccd10225154425edc69 I used
> `llvm-test-suite/MultiSource/Benchmarks/` for all tests.
>

The names of the tests in the report don't seem to match. For instance
treeadd.test does not appear in the baseline test.

David



>
> > 1. is MIP used in the test only for function coverage or have call
> counts collected as well?
>
> Just function coverage for simplicity, but full MIP does not add very much
> to the size.
>
> > 2. for -fcs-profile-generate, the size increase may mostly come from the
> name section. Can you compare .text + .data + .bss
>
> Sure, I can do this next week.
>
>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D104060/new/
>
> https://reviews.llvm.org/D104060
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210611/a5460752/attachment.html>