[PATCH] D104037: [X86] Check immediate before get it.

Fri Jun 11 19:58:07 PDT 2021

LuoYuanke added a comment.

In D104037#2813726 <https://reviews.llvm.org/D104037#2813726>, @craig.topper wrote:

> I don't what Intel's original failure looked like, but here's a test that should reproduce this with -run-pass=machinelicm   https://reviews.llvm.org/P8267  needs more cleanup.
>
> I hacked the MIR just before machinelicm by sinking the CMP64mi32 and SETCCr into the loop. That makes MachineLICM want to unfold it since the load part is invariant being from a constant global.

Hi Craig,

Awesome.  Many thanks for the test case. I applied your test case to this patch.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104037/new/

https://reviews.llvm.org/D104037