[PATCH] D104060: Machine IR Profile

Xinliang David Li via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 11 17:09:16 PDT 2021


On Fri, Jun 11, 2021 at 4:40 PM Ellis Hoag via Phabricator <
reviews at reviews.llvm.org> wrote:

> ellis added a comment.
>
> In D104060#2814525 <https://reviews.llvm.org/D104060#2814525>, @davidxl
> wrote:
>
> > Do you have runtime number with -fcs-profile-generate -mllvm
> > -disable-vp=true
> >
> > This will provide more data (BB count) than what MIP can do.
> >
> > Besides, more options can be added to control the type of profile data
> > collected in IRPGO to further reduce overhead.
> >
> > David
>
> I've added those numbers here
> https://gist.github.com/ellishg/92a68cf82bfdeccd10225154425edc69#gistcomment-3777527
>
> The flags `-fcs-profile-generate -mllvm -disable-vp=true` appears to
> increase binary size by 4-9x and execution time is increased in many cases.
>
>
Can you use the same set of benchmarks for comparison?

1) is MIP used in the test only for function coverage or have call counts
collected as well?
2) for -fcs-profile-generate, the size increase may mostly come from the
name section. Can you compare .text + .data + .bss
David

>
> Repository:
>   rG LLVM Github Monorepo
>
> CHANGES SINCE LAST ACTION
>   https://reviews.llvm.org/D104060/new/
>
> https://reviews.llvm.org/D104060
>
>
-------------- next part --------------
An HTML attachment was scrubbed...
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210611/725fdd0e/attachment.html>


More information about the llvm-commits mailing list