[PATCH] D103089: [Debug-Info][CodeView] Fix GUID string generation for MSVC generated objects.

Adrian McCarthy via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 11 15:01:06 PDT 2021


amccarth accepted this revision.
amccarth added a comment.
This revision is now accepted and ready to land.

Thanks for the changes.  This LGTM now.



================
Comment at: llvm/unittests/DebugInfo/CodeView/GUIDFormatTest.cpp:93
+
+      // Shif 2 (0x00) across all components
+      {"00003344-5566-7788-99AA-BBCCDDEEFFAA",
----------------
nit:  s/Shif/Shift/


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103089/new/

https://reviews.llvm.org/D103089



More information about the llvm-commits mailing list