[PATCH] D104151: [docs][OpaquePtr] Shuffle around the transition plan section

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Sounds good to me - couple of optional comments/questions that could be clarified in the text.



================
Comment at: llvm/docs/OpaquePointers.rst:118
 
-* Fix up existing in-tree users of pointee types to not rely on LLVM pointer
-  pointee types
+  * This may already be done
 
----------------
May be confusing to say "This may already be done" when the line before sort of seems like it says "this is already done".

Maybe rephrase this to "More cases may be found as work continues"?


================
Comment at: llvm/docs/OpaquePointers.rst:140-143
+* Figure out how to name overloaded intrinsics with pointer parameters
+
+  * See ``getMangledTypeStr()``
+
----------------
Oh, yeah. I remember that one.

Are there cases you know of where we will need overloading based on pointee type? Or might it be a case of mangling opaque pointer types as opaque being sufficient?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104151/new/

https://reviews.llvm.org/D104151