[PATCH] D104084: [lld-macho] Add options -(no_)keep_dwarf_unwind

[Nico Weber via Phabricator via llvm-commits]

thakis added a comment.

In D104084#2813716 <https://reviews.llvm.org/D104084#2813716>, @gkm wrote:

> In D104084#2813364 <https://reviews.llvm.org/D104084#2813364>, @thakis wrote:
>
>> The intelligent approach isn't _that_ hard, is it? It's < 200 lines in ld64 I think. ld64-linked Chromium Framework leaves some __eh_frame around, so I think removing the whole section generally probably doesn't work.
>
> Yes, I will do it, but wanted this out quickly. (I changed the description to read "... unless and until (maybe later today!) we have a use case ..." :)
>
> When I looked at the CU entries for Chromium Framework, I saw none that had type bits [24..27] == 4, which means `UNWIND_X86_64_MODE_DWARF`. What am I not seeing?

I didn't look in detail, I just noticed that ld64 keeps some of the section. So I thought the bits that remain are probably needed? Not sure though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104084/new/

https://reviews.llvm.org/D104084