[PATCH] D103867: [CHR] Don't run ControlHeightReduction if any BB has address taken

Hongtao Yu via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 11 12:17:32 PDT 2021


hoy accepted this revision.
hoy added a comment.

In D103867#2806612 <https://reviews.llvm.org/D103867#2806612>, @aeubanks wrote:

> do all passes that clone BBs have to worry about this?

I think so. We've seen a similar case in inlining where an address-taken block was inlined. The inlining should be disabled as well.

LGTM, thanks for the fix.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103867/new/

https://reviews.llvm.org/D103867



More information about the llvm-commits mailing list