[PATCH] D103480: [NFC][OpaquePtr] Explicitly pass GEP source type in optimizeGatherScatterInst()

Craig Topper via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 11 11:17:13 PDT 2021


craig.topper added inline comments.


================
Comment at: llvm/lib/CodeGen/CodeGenPrepare.cpp:5601
+    else
+      ScalarTy = MemoryInst->getOperand(0)->getType()->getScalarType();
+    NewAddr = Builder.CreateGEP(ScalarTy, V, Constant::getNullValue(IndexTy));
----------------
assert the else path is masked_scatter? Or pass the type down from the caller like we do with the pointer operand.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103480/new/

https://reviews.llvm.org/D103480



More information about the llvm-commits mailing list