[PATCH] D103971: [lld-macho] Don't check for flag-mismatch if flag isn't set.

[Vy Nguyen via Phabricator via llvm-commits]

oontvoo added a comment.

In D103971#2808327 <https://reviews.llvm.org/D103971#2808327>, @int3 wrote:

> Could you add a test?

Yup, I'll try to simplify the test case we had that tripped over this.

But can we first agree on the logic?  If the flag is not set, then it should not be a flag or type conflict. Does that make sense?

(also the comment on top of this function is ... interesting  :-) `" this is most likely wrong;  ...The logic presented here was written without any form of informed research."`. )


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103971/new/

https://reviews.llvm.org/D103971