[PATCH] D104007: [BasicAA] Properly mark that coroutine suspension may modify parameters

Xun Li via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 11 08:21:49 PDT 2021


lxfind added a comment.

In D104007#2812536 <https://reviews.llvm.org/D104007#2812536>, @efriedma wrote:

> If you fix the clang code so it isn't generating these extra useless allocas, the problem with byval should become obvious: even without any optimizations, we end up with a use-after-free.  corosplit isn't preserving memory that's supposed to be part of the callee frame.

Thanks. I get your points now.
Do you know if there is a stable contract in IR to tell whether an argument is in fact a callee-owned memory?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104007/new/

https://reviews.llvm.org/D104007



More information about the llvm-commits mailing list