[PATCH] D104123: [llvm][AArch64] Handle arrays of struct properly (from IR)

David Spickett via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 11 08:17:18 PDT 2021


DavidSpickett added a comment.

Though globalisel doesn't crash with the reported snippet, it does crash on the added tests when we spill to memory. I still need to look into that but I don't think it should block this. (unless the bug reporter turns out to be using globalisel)

On the subject of not being ABI compliant when going direct from IR, here's an example of that: https://godbolt.org/z/oMcPd87nc , this doesn't make the situation any worse.

We started considering more types for register blocks after https://reviews.llvm.org/D61259 but there is no fault in that commit's usage of it. It simply uncovered something that already existed.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104123/new/

https://reviews.llvm.org/D104123



More information about the llvm-commits mailing list