[PATCH] D103636: [AMDGPU][IndirectCalls] Fix register usage propagation for indirect/external calls

[Matt Arsenault via Phabricator via llvm-commits]

arsenm accepted this revision.
arsenm added inline comments.
This revision is now accepted and ready to land.


================
Comment at: llvm/lib/Target/AMDGPU/AMDGPUSubtarget.cpp:726-727
+  bool FunctionHasFlatScratchInit = false;
+  bool HasCalls = F.hasFnAttribute("amdgpu-calls");
+  bool HasStackObjects = F.hasFnAttribute("amdgpu-stack-objects");
+  if (hasFlatAddressSpace() && AMDGPU::isEntryFunctionCC(F.getCallingConv()) &&
----------------
madhur13490 wrote:
> arsenm wrote:
> > I don't like relying on these attributes. Can you just assume they are true?
> But that will deviate from the current behavior. 
OK, as a followup change, can you just make these assume true?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103636/new/

https://reviews.llvm.org/D103636