[PATCH] D103490: [SystemZ][z/OS] Add support for TXT records in the GOFF reader

[Yusra Syeda via Phabricator via llvm-commits]

yusra.syeda marked 2 inline comments as done.
yusra.syeda added inline comments.


================
Comment at: llvm/include/llvm/Object/GOFF.h:103
+
+  static void getElementEsdId(const uint8_t *Record, uint32_t &EsdId) {
+    get<uint32_t>(Record, 4, EsdId);
----------------
jhenderson wrote:
> What's the motivation for returning by updating an input parameter, rather than returning via the return type?
There is no specific reason, I have changed it to return the type.


================
Comment at: llvm/include/llvm/Object/GOFFObjectFile.h:33
 class GOFFObjectFile : public ObjectFile {
+  friend class GOFFSymbolRef;
+
----------------
jhenderson wrote:
> There may be a perfectly valid reason for this, but why make this a friend class rather than just making the relevant functions public?
It's also done this way in ELFObjectFile.h, so this follows


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103490/new/

https://reviews.llvm.org/D103490