[llvm] 7b444a6 - Fix for error "'Run' overrides a member function but is not marked

Zahira Ammarguellat via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 11 06:56:11 PDT 2021


Author: Zahira Ammarguellat
Date: 2021-06-11T06:56:00-07:00
New Revision: 7b444a66b33ca7ec9cc7b9737205805e9d8106a2

URL: https://github.com/llvm/llvm-project/commit/7b444a66b33ca7ec9cc7b9737205805e9d8106a2
DIFF: https://github.com/llvm/llvm-project/commit/7b444a66b33ca7ec9cc7b9737205805e9d8106a2.diff

LOG: Fix for error "'Run' overrides a member function but is not marked
'override' [-Werror,-Wsuggest-override]" occuring during windows
debug self-build.

Added: 
    

Modified: 
    llvm/lib/Testing/Support/CMakeLists.txt

Removed: 
    


################################################################################
diff  --git a/llvm/lib/Testing/Support/CMakeLists.txt b/llvm/lib/Testing/Support/CMakeLists.txt
index bde4e1d64f15a..1830ea88bb3fa 100644
--- a/llvm/lib/Testing/Support/CMakeLists.txt
+++ b/llvm/lib/Testing/Support/CMakeLists.txt
@@ -13,3 +13,12 @@ add_llvm_library(LLVMTestingSupport
   )
 
 target_link_libraries(LLVMTestingSupport PRIVATE gtest)
+
+# This is to avoid the error in gtest-death-test-internal.h
+# (150,16): error: 'Create' overrides a member function but
+# is not marked 'override' [-Werror,-Wsuggest-override]
+# during self-compile on Windows.
+
+if (HOST_WINNT AND "${CMAKE_CXX_COMPILER_ID}" MATCHES "Clang" )
+  SET(CMAKE_CXX_FLAGS "${CMAKE_CXX_FLAGS} -Wno-suggest-override")
+endif()


        


More information about the llvm-commits mailing list