[PATCH] D93838: [SCCP] Add Function Specialization pass

Sjoerd Meijer via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 11 01:51:15 PDT 2021


SjoerdMeijer added a comment.

In D93838#2812661 <https://reviews.llvm.org/D93838#2812661>, @fhahn wrote:

> I'm not quite sure why the implementation is in `llvm/lib/Transforms/Scalar/FunctionSpecialization.cpp`, rather than `llvm/lib/Transforms/IPO/FunctionSpecialization.cpp`? It's interprocedural only, right? The implementation in `SCCP.cpp` works on both a single function and a module, that's probably with its in the `Scalar` sub-directory.  It's also a separate pass from `IPSCCP`, so I am not sure if the pass definition should be in `llvm/lib/Transforms/IPO/SCCP.cpp`.

Thanks, I will follow up on this shortly (i.e., will prepare a diff). I can't remember if there was something with this pass definition, but will look.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93838/new/

https://reviews.llvm.org/D93838



More information about the llvm-commits mailing list