[PATCH] D93838: [SCCP] Add Function Specialization pass

[Florian Hahn via Phabricator via llvm-commits]

fhahn added inline comments.


================
Comment at: llvm/include/llvm/Transforms/Utils/SCCPSolver.h:146
+  /// completely specialized and is no longer needed).
+  void markFunctionUnreachable(Function *F);
+
----------------
unused?


================
Comment at: llvm/include/llvm/Transforms/Utils/SCCPSolver.h:148
+
+  void visit(Instruction *I);
+  void visitCall(CallInst &I);
----------------
unused?


================
Comment at: llvm/include/llvm/Transforms/Utils/SCCPSolver.h:149
+  void visit(Instruction *I);
+  void visitCall(CallInst &I);
 };
----------------
unused?


================
Comment at: llvm/lib/Transforms/Scalar/FunctionSpecialization.cpp:216
+        // with the given value.
+        Solver.markArgInFuncSpecialization(F, ClonedArg, C);
+
----------------
Is this needed in the latest version? If it is not needed, please also remove it from the interface.


================
Comment at: llvm/lib/Transforms/Scalar/FunctionSpecialization.cpp:509
+    for (auto *CS : CallSitesToRewrite) {
+
+      if ((CS->getFunction() == Clone && CS->getArgOperand(ArgNo) == &Arg) ||
----------------
stray newline?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93838/new/

https://reviews.llvm.org/D93838