[PATCH] D104092: [llvm-objcopy][MachO] Keep symbols having the flag REFERENCED_DYNAMICALLY set

James Henderson via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Fri Jun 11 00:57:33 PDT 2021


jhenderson accepted this revision.
jhenderson added a comment.

LGTM, with nit.



================
Comment at: llvm/test/tools/llvm-objcopy/MachO/Inputs/strip-all-with-dwarf.yaml:295
+      n_sect:          1
+      n_desc:          16
+      n_value:         4294967296
----------------
It's probably worth a comment showing what this `n_desc` value represents.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104092/new/

https://reviews.llvm.org/D104092



More information about the llvm-commits mailing list