[PATCH] D102145: [Coroutines] Add `llvm.coro.align`, `llvm.coro.raw.frame.ptr.offset` and `llvm.coro.raw.frame.ptr.addr` intrinsics

Thu Jun 10 23:10:27 PDT 2021

ychen added a comment.

In D102145#2809809 <https://reviews.llvm.org/D102145#2809809>, @ChuanqiXu wrote:

> It looks like that other reviewers are not available at this time. I am curious about the alignment problem for coroutine frame since I met confusing regression problem due to alignment mismatch in the past. Although the condition to trigger the alignment mismatch problem is not common (it requires the user to specify the alignment for a variable with alignment large than 16), I am desired to complete the (series) patch(es). So again, it looks better for me to merge this with  D97915 <https://reviews.llvm.org/D97915> to review and test. How do you think about it @ychen ?

Thanks for taking another look. Sure, I'll update the patch tomorrow.

Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D102145/new/

https://reviews.llvm.org/D102145