[PATCH] D104037: [X86] Check immediate before get it.

[Craig Topper via Phabricator via llvm-commits]

craig.topper added a comment.

It would be nice to have a test, but this change seems ok.



================
Comment at: llvm/lib/Target/X86/X86InstrInfo.cpp:6410
   case X86::CMP8ri: {
     MachineOperand &MO0 = DataMI->getOperand(0);
     MachineOperand &MO1 = DataMI->getOperand(1);
----------------
pengfei wrote:
> But `CMP64mi32` shouldn't go to here.
The CMPmi32 will be expanded to a load and CMPri32. This switches use the opcode after it's expanded.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104037/new/

https://reviews.llvm.org/D104037