[PATCH] D103292: [lld-macho] Implement ICF

[Jez Ng via Phabricator via llvm-commits]

int3 added inline comments.


================
Comment at: lld/MachO/ICF.cpp:107
+                          const auto *db = dyn_cast<DylibSymbol>(sb);
+                          if (da->stubsHelperIndex != db->stubsHelperIndex)
+                            return false;
----------------
int3 wrote:
> do we need to compare `gotIndex` too?
actually... since ICF doesn't fold DylibSymbols, can we not just check for pointer equality of the DylibSymbols here?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103292/new/

https://reviews.llvm.org/D103292