[PATCH] D101332: [llvm-objcopy] Exclude empty sections in IHexWriter output

Ian McIntyre via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 10 15:32:58 PDT 2021


mciantyre marked 5 inline comments as done.
mciantyre added inline comments.


================
Comment at: llvm/test/tools/llvm-objcopy/ELF/ihex-writer-empty-sections.test:57
+    AddressAlign:     0x1
+    Content:          "000102030405060708090A0B0C0D0E0F"
+## An empty section that's placed at the end of .data0. This won't
----------------
jhenderson wrote:
> I'm guessing the exact content isn't really important, in which case, I'd just go with something that's 2 or 4 bytes long for brevity (e.g. "0123"). Same goes elsewhere.
Simplified contents, and corrected addresses throughout.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101332/new/

https://reviews.llvm.org/D101332



More information about the llvm-commits mailing list