[PATCH] D87302: [IRSim][IROutliner] Adding DebugInfo handling for IR outlined functions.

[Jessica Paquette via Phabricator via llvm-commits]

paquette added a comment.

In D87302#2811182 <https://reviews.llvm.org/D87302#2811182>, @dblaikie wrote:

> Does the outliner only run for commoning code, or can it run on a single function (for hot/cold reasons, or anything else)?
>
> BUt yeah, in the commoning case, DWARF (& LLVM IR) have no way to represent this situation and dropping the location is the best tool we have at the moment. It's discussed here: https://llvm.org/docs/HowToUpdateDebugInfo.html#when-to-drop-an-instruction-location

Right now, it's module-only. A single-function outlining pass would be pretty useful though. (E.g. for matching outlinable patterns stored off somewhere else.)

Anyway, as for debug info with outlining, yeah, I think that would need a DWARF extension. (@aprantl might be interested in that topic?) I think that discussion is probably better-suited to an email thread on a few mailing lists though. :)

For the sake of this patch, @AndrewLitteken, I think all you need to do is tidy up the testcase like @djtodoro suggested. (Does update_test_checks.py hardcode metadata stuff like this?)


CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D87302/new/

https://reviews.llvm.org/D87302