[PATCH] D97982: [MC] Introduce NeverAlign fragment type

Eli Friedman via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 10 13:27:54 PDT 2021


efriedma added a comment.

In D97982#2811362 <https://reviews.llvm.org/D97982#2811362>, @Amir wrote:

> In D97982#2811315 <https://reviews.llvm.org/D97982#2811315>, @efriedma wrote:
>
>>> Which disables NeverAlign padding (0 bytes)
>>
>> When do we actually do this computation?  At first glance, MCAssembler::layoutSectionOnce never actually goes back to recompute the size of the NeverAlign padding.
>
> There's one invocation of computeFragmentSize which would set the final size of NeverAlign fragment in MCAssembler::finishLayout, which is performed after layoutSectionOnce/layoutOnce is done.

That's not going to work out in general.  Removing the NeverAlign padding can increase the distance between two symbols if .palign is involved.  That might require relaxation.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D97982/new/

https://reviews.llvm.org/D97982



More information about the llvm-commits mailing list