[PATCH] D93659: [AIX][XCOFF] emit vector info of traceback table.

Digger Lin via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 10 13:20:46 PDT 2021


DiggerLin marked 5 inline comments as done.
DiggerLin added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCMachineFunctionInfo.cpp:138-141
+    if (Elt == FixedType && !hasVectorParms() && Bits > 31)
+      break;
+    if ((Elt != FixedType || hasVectorParms()) && Bits > 30)
+      break;
----------------
jasonliu wrote:
> DiggerLin wrote:
> > jasonliu wrote:
> > > Could we combine the above two if statement?
> > can not combine it, for Elt == FixedType && !hasVectorParms()  , it only need one bit, so when Bits ==31, we can still put one bit of FixedType which do not have hasVectorParms().
> So what would not work for the suggestions I made? 
change as suggestion, thanks



Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D93659/new/

https://reviews.llvm.org/D93659



More information about the llvm-commits mailing list