[PATCH] D104055: Override ffp-contract to fast due to command line changes planned in D74436

Melanie Blower via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 10 13:18:36 PDT 2021


mibintc created this revision.
mibintc added reviewers: rengolin, sebpop, kbsmith1, andrew.w.kaylor, jdoerfert, fhahn, kristof.beyls.
Herald added subscribers: pengfei, dmgreen, mgorny.
mibintc requested review of this revision.
Herald added a project: LLVM.
Herald added a subscriber: llvm-commits.

The previous patch https://reviews.llvm.org/D102861 suppressed ffp-contract but that was wrong, the change should be to set ffp-contract=fast.
When I applied the clang patch, the same tests failed again, this time due to execution_time.
Also the previous patch limited the changes to x86, but they are also needed broadly on all architectures so I changed that too in this revision.

I could revert the previous patch and roll them both into a single patch, what do you think?


Repository:
  rG LLVM Github Monorepo

https://reviews.llvm.org/D104055

Files:
  MicroBenchmarks/ImageProcessing/BilateralFiltering/CMakeLists.txt
  MicroBenchmarks/ImageProcessing/Blur/CMakeLists.txt
  MultiSource/Applications/oggenc/CMakeLists.txt
  MultiSource/Benchmarks/DOE-ProxyApps-C++/CLAMR/CMakeLists.txt
  MultiSource/Benchmarks/DOE-ProxyApps-C++/HPCCG/CMakeLists.txt
  MultiSource/Benchmarks/DOE-ProxyApps-C++/miniFE/CMakeLists.txt
  MultiSource/Benchmarks/Rodinia/srad/CMakeLists.txt
  SingleSource/Benchmarks/Linpack/CMakeLists.txt
  SingleSource/Benchmarks/Misc-C++/Large/CMakeLists.txt
  SingleSource/Benchmarks/Polybench/datamining/correlation/CMakeLists.txt
  SingleSource/Benchmarks/Polybench/datamining/covariance/CMakeLists.txt
  SingleSource/Benchmarks/Polybench/linear-algebra/kernels/2mm/CMakeLists.txt
  SingleSource/Benchmarks/Polybench/linear-algebra/kernels/3mm/CMakeLists.txt
  SingleSource/Benchmarks/Polybench/linear-algebra/kernels/atax/CMakeLists.txt
  SingleSource/Benchmarks/Polybench/linear-algebra/kernels/bicg/CMakeLists.txt
  SingleSource/Benchmarks/Polybench/linear-algebra/kernels/gemver/CMakeLists.txt
  SingleSource/Benchmarks/Polybench/linear-algebra/kernels/gesummv/CMakeLists.txt
  SingleSource/Benchmarks/Polybench/linear-algebra/kernels/symm/CMakeLists.txt
  SingleSource/Benchmarks/Polybench/linear-algebra/kernels/trisolv/CMakeLists.txt
  SingleSource/Benchmarks/Polybench/linear-algebra/kernels/trmm/CMakeLists.txt
  SingleSource/Benchmarks/Polybench/linear-algebra/solvers/gramschmidt/CMakeLists.txt
  SingleSource/Benchmarks/Polybench/stencils/adi/CMakeLists.txt
  SingleSource/UnitTests/Vector/SSE/CMakeLists.txt

-------------- next part --------------
A non-text attachment was scrubbed...
Name: D104055.351245.patch
Type: text/x-patch
Size: 16309 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210610/c7906c0c/attachment-0001.bin>


More information about the llvm-commits mailing list