[PATCH] D103888: [ADT] Remove APInt/APSInt toString() std::string variants

[David Blaikie via Phabricator via llvm-commits]

dblaikie accepted this revision.
dblaikie added a comment.
This revision is now accepted and ready to land.

Sounds OK.

I wouldn't mind the places that can use op<< to use that - not sure preserving the explicit radix argument is super high value. (I think people would generally assume that's the default)
Possible we could call it `to_string`, is std::to_string meant to be an ADL extension point, so that other types expose a to_string in their own associated namespace, etc?



================
Comment at: llvm/unittests/ADT/APIntTest.cpp:1459-1466
 TEST(APIntTest, mul_clear) {
   APInt ValA(65, -1ULL);
   APInt ValB(65, 4);
   APInt ValC(65, 0);
   ValC = ValA * ValB;
   ValA *= ValB;
+  EXPECT_EQ(toString(ValA, 10, false), toString(ValC, 10, false));
----------------
Perhaps this test should move to the StringExtras unit test?


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103888/new/

https://reviews.llvm.org/D103888