[PATCH] D103409: [PowerPC] Allow wa inline asm to also accept floating point arguments

Nemanja Ivanovic via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 10 12:17:09 PDT 2021


nemanjai accepted this revision.
nemanjai added a comment.
This revision is now accepted and ready to land.

LGTM.



================
Comment at: llvm/lib/Target/PowerPC/PPCISelLowering.cpp:15651
              Subtarget.hasVSX()) {
-    return std::make_pair(0U, &PPC::VSRCRegClass);
+    if (VT.isVector())
+      return std::make_pair(0U, &PPC::VSRCRegClass);
----------------
A comment above this line would be useful:
```
// A VSX register for either a scalar (FP) or vector. There is no
// support for single precision scalars on subtargets prior to Power8.
```


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103409/new/

https://reviews.llvm.org/D103409



More information about the llvm-commits mailing list