[PATCH] D103811: [docs] Set Phabricator as the tool for pre-commit code reviews

[David Blaikie via Phabricator via llvm-commits]

dblaikie added a subscriber: mehdi_amini.
dblaikie added a comment.

In D103811#2810887 <https://reviews.llvm.org/D103811#2810887>, @beanz wrote:

> So, I realize I probably should have mentioned this earlier on the llvm-dev thread, but is this really a change we should be making the week after Phabricator officially became an unsupported project:
>
> https://admin.phacility.com/phame/post/view/11/phacility_is_winding_down_operations/
>
> I feel like in practice we use Phabricator and not really pre-commit email reviews, so this might just be formalizing the practice, but Phabricator not being officially maintained means that we'll likely need to move off it at some point, so this policy change would likely be short lived.

Good to know (+ at mehdi_amini) - but given this is a small/simple textual change and codifies existing practice, I'm still good with this change.

But I agree this does mean we need to be re-evaluating our tooling around code reviews, and might help push things in the direction of moving to pull requests, for instance.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103811/new/

https://reviews.llvm.org/D103811