[PATCH] D104028: [WIP] Use standard priority queue to order inlining

[Mircea Trofin via Phabricator via llvm-commits]

mtrofin added inline comments.


================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:707
 
-  reference front() override {
+  T front() override {
     assert(size() > 0);
----------------
you can also delay pop-ing. Or, better, have pop return T, and front return reference and be a const function (i.e. a peek - you need it I think in the for loop, line 899).


================
Comment at: llvm/lib/Transforms/IPO/Inliner.cpp:824
   // incrementally maknig a single function grow in a super linear fashion.
-  DefaultInlineOrder<std::pair<CallBase *, int>> Calls;
+  PriorityInlineOrder Calls;
 
----------------
add a flag to this file to control which InlineOrder you use.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104028/new/

https://reviews.llvm.org/D104028