[PATCH] D91722: [DebugInfo] Use variadic debug values to salvage BinOps and GEP instrs with non-const operands

[Stephen Tozer via Phabricator via llvm-commits]

StephenTozer added inline comments.


================
Comment at: llvm/lib/Transforms/Utils/Local.cpp:1862
+  }
+  for (auto Offset : VariableOffsets) {
+    AdditionalValues.push_back(Offset.first);
----------------
hans wrote:
> aeubanks wrote:
> > could this be causing non-determinism?
> I tried changing VariableOffsets into a MapVector, but that wasn't enough to make the output of my reproducer deterministic.
This is a potential source of non-determinism, but in this case it was actually in a different piece of code from an earlier patch, although this patch depends on that one and exposes the incorrect behaviour. I'm opening up a patch to fix that other incorrect behaviour, and will also fix this in the next reapply.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D91722/new/

https://reviews.llvm.org/D91722