[PATCH] D103977: [lld-macho][nfc] Move liveness-tracking fields into ConcatInputSection

[Nico Weber via Phabricator via llvm-commits]

thakis accepted this revision.
thakis added a comment.
This revision is now accepted and ready to land.

This change as-is is fine.

But overall, it feels like things get a lot more complicated because we're not creating real InputSections for each literal in literal sections. Are there so many more literals than normal symboled inputsections? What's the memory / perf hit from just having normal InputSections for each literal?



================
Comment at: lld/MachO/MarkLive.cpp:165
     for (InputSection *isec : inputSections) {
+      if (!isa<ConcatInputSection>(isec))
+        continue;
----------------
thakis wrote:
> Is that correct? Imagine a S_ATTR_LIVE_SUPPORT symbol pointing to a live literal.
Nevermind, this is the referring section, not the referent.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103977/new/

https://reviews.llvm.org/D103977