[PATCH] D103833: [demangler] Fix demangling of 'half'

James Y Knight via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 10 05:46:27 PDT 2021


jyknight added a comment.

A git diff generally has an extraneous path component [ab] first, e.g. your diff should look like this:

  diff --git a/libcxxabi/src/demangle/ItaniumDemangle.h b/libcxxabi/src/demangle/ItaniumDemangle.h
  index 4e3af0cb2649..78035c38ee50 100644
  --- a/llvm/include/llvm/Demangle/ItaniumDemangle.h
  +++ b/llvm/include/llvm/Demangle/ItaniumDemangle.h

but your diff excerpt in the comment above is missing that extra directory prefix. I suspect you've got a local configuration file setting `diff.noprefix = true` -- and unfortunately, while omitting the a/b prefixes is nicer for humans, it confuses most git tooling, which expects it to be present -- including git itself, e.g. `git apply`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103833/new/

https://reviews.llvm.org/D103833



More information about the llvm-commits mailing list