[PATCH] D103880: [SDAG] Fix pow2 assumption when splitting vectors
Carl Ritson via Phabricator via llvm-commits
llvm-commits at lists.llvm.org
Thu Jun 10 03:54:46 PDT 2021
critson updated this revision to Diff 351120.
critson marked an inline comment as done.
critson added a comment.
- Replace getVectorMinNumElements with getVectorNumElements
Repository:
rG LLVM Github Monorepo
CHANGES SINCE LAST ACTION
https://reviews.llvm.org/D103880/new/
https://reviews.llvm.org/D103880
Files:
llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
Index: llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
===================================================================
--- llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
+++ llvm/lib/CodeGen/SelectionDAG/DAGCombiner.cpp
@@ -19362,7 +19362,9 @@
unsigned SplitSize = NearestPow2 / 2;
EVT SplitVT = EVT::getVectorVT(*DAG.getContext(),
InVT.getVectorElementType(), SplitSize);
- if (TLI.isTypeLegal(SplitVT)) {
+ if (TLI.isTypeLegal(SplitVT) &&
+ SplitSize + SplitVT.getVectorNumElements() <=
+ InVT.getVectorNumElements()) {
SDValue VecIn2 = DAG.getNode(ISD::EXTRACT_SUBVECTOR, DL, SplitVT, Vec,
DAG.getVectorIdxConstant(SplitSize, DL));
SDValue VecIn1 = DAG.getNode(ISD::EXTRACT_SUBVECTOR, DL, SplitVT, Vec,
-------------- next part --------------
A non-text attachment was scrubbed...
Name: D103880.351120.patch
Type: text/x-patch
Size: 847 bytes
Desc: not available
URL: <http://lists.llvm.org/pipermail/llvm-commits/attachments/20210610/db440feb/attachment.bin>
More information about the llvm-commits
mailing list