[PATCH] D103833: [demangler] Fix demangling of 'half'

[Stuart Brady via Phabricator via llvm-commits]

stuart added subscribers: klimek, chandlerc.
stuart added a comment.

@jyknight, I have reuploaded the exact same diff with full context:

  diff --git libcxxabi/src/demangle/ItaniumDemangle.h libcxxabi/src/demangle/ItaniumDemangle.h
  --- libcxxabi/src/demangle/ItaniumDemangle.h
  +++ libcxxabi/src/demangle/ItaniumDemangle.h
  @@ -1,5713 +1,5713 @@
  [...]
  diff --git llvm/include/llvm/Demangle/ItaniumDemangle.h llvm/include/llvm/Demangle/ItaniumDemangle.h
  index 4e3af0cb2649..78035c38ee50 100644
  --- llvm/include/llvm/Demangle/ItaniumDemangle.h
  +++ llvm/include/llvm/Demangle/ItaniumDemangle.h
  @@ -1,5713 +1,5713 @@
  [...]

"Download raw diff" //still// downloads an adjusted version of the diff with the context removed, and with the paths mangled (ironically) by Differential.

The full context is visible in Differential's pretty-printing of the diff. I believe the context would not be visible had I not included it in the patch as submitted.

Perhaps the path of "llvm/include/llvm" is confusing it. This change does apply to both libcxxapi and llvm, but I would prefer not to split it up if there is no need.

@klimek, @chandlerc, would you have any advice? I've read the //Code Reviews with Phabricator// guide (and also the //LLVM Developer Policy//) and can't see anything there that would indicate that I'm doing anything wrong.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103833/new/

https://reviews.llvm.org/D103833