[PATCH] D103010: [PowerPC] Export 16 byte load-store instructions

[Nemanja Ivanovic via Phabricator via llvm-commits]

nemanjai added inline comments.


================
Comment at: llvm/lib/Target/PowerPC/PPCInstr64Bit.td:286
+def LQARXL : XForm_1<31, 276, (outs g8prc:$RTp), (ins memrr:$ptr),
+                     "lqarx $RTp, $ptr, 1", IIC_LdStLQARX, []>, isRecordForm;
 
----------------
lkail wrote:
> jsji wrote:
> > `isRecordForm` ?  lqarx is not a recordform, stdcx. is a record form.
> This should be a historical issue(IIUC, to avoid decoding conflict), I'll leave `L(B|W|D|Q)ARXL` as it is now and fix them in following patches.
The `L` variant is a hinted variant and the hint sets the same bit as record-form instructions. So we just reuse that bit. There is no danger of `PPCInstrInfo::optimizeCompareInstr()` attempting to convert one to the other since this is not part of the `RecFormRel` relation.

So I don't really think there is anything here that needs fixing.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103010/new/

https://reviews.llvm.org/D103010