[PATCH] D103225: [AMDGPU] Replace non-kernel function uses of LDS globals by pointers.

Mahesha S via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 10 02:33:33 PDT 2021


hsmhsm marked 4 inline comments as done.
hsmhsm added a comment.

In D103225#2809859 <https://reviews.llvm.org/D103225#2809859>, @foad wrote:

>> practically speaking we can do without mbcnt_hi, but may be it is good and safe to have mbcnt_hi for wave64
>
> I am baffled by this. Why would you add an extra instruction when you have just explained that it is not required?

Correct, but, I myself could not confidently prove that it is always safe to use only mbcnt_lo even for wave64 mode, hence had to insert mbcnt_hi for wave64 mode.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103225/new/

https://reviews.llvm.org/D103225



More information about the llvm-commits mailing list