[PATCH] D101103: [InstSimplify] Treat invariant group insts as bitcasts for load operands

Roman Lebedev via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 10 02:09:26 PDT 2021


lebedev.ri added inline comments.


================
Comment at: llvm/lib/Analysis/InstructionSimplify.cpp:5825-5826
+  Worklist.push_back(Op);
+  while (true) {
+    Value *CurOp = Worklist.back();
+    if (isa<Constant>(CurOp))
----------------
Then i guess you want to add a `SmallPtrSet<Value*> Visited;` outside of the loop
insert into it in the beginning of the loop, and if insertion fails - `return nullptr;`.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D101103/new/

https://reviews.llvm.org/D101103



More information about the llvm-commits mailing list