[PATCH] D103622: [RISCV] Avoid scalar outgoing arguments overwriting vector frame objects.

Fraser Cormack via Phabricator via llvm-commits llvm-commits at lists.llvm.org
Thu Jun 10 01:57:58 PDT 2021


frasercrmck accepted this revision.
frasercrmck added a comment.
This revision is now accepted and ready to land.

LGTM other than my last question. Thanks!



================
Comment at: llvm/lib/Target/RISCV/RISCVFrameLowering.cpp:924
+// function contains variable size objects or there are vector objects accessed
+// by the stack pointer.
+// Let eliminateCallFramePseudoInstr preserve stack space for it.
----------------
I was expecting this to say "frame pointer" given my understanding and the code. It's very possible I'm mistaken, though.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D103622/new/

https://reviews.llvm.org/D103622



More information about the llvm-commits mailing list