[PATCH] D104007: [BasicAA] Properly mark that coroutine suspension may modify parameters

[Chuanqi Xu via Phabricator via llvm-commits]

ChuanqiXu added a comment.

Great! Although I am not expect for AA, the general idea looks natural and proper to me. Previously, we think we should handle coroutine in the coroutine module and don't pollute other passes about the meaning of coroutine. On one hand, it looks not easy or not cheap to handle these semantics for coroutine in the coroutine module only. On the other hand, it is really natural to add it in AA since after suspend the argument is really possible be modified.

Although it may be restrict now, I think we could relax them in the future. For example, we could extract a analysis pass from coroutine and the AA could get information from that analysis pass to make more precise analysis.


Repository:
  rG LLVM Github Monorepo

CHANGES SINCE LAST ACTION
  https://reviews.llvm.org/D104007/new/

https://reviews.llvm.org/D104007